Adding country functionality from metadata #410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Nov 1, 2016
|
Something is wrong here. Moment should not be in the source. |
|
I'm not sure how that happened! Do I need to run "grunt clean"?
|
|
You've committed way more files than are actually part of the project. Did you maybe modify or delete your |
|
I can jump onto this @alexgrace95 if you're busy right now. It should be a quick fix, or we can chat online about how to fix this. |
|
@alexgrace95 - ping |
|
Hi @mj1856 & @marwahaha. |
|
I have removed Moment from the source (I think may have been caused by running "bower install" at some point) and resolved the conflicts. |
|
Please rebase |
|
Out of curiosity @mj1856 , what's wrong with a squash and merge? Just trying to understand. |
added 2 commits
December 24, 2016 00:03
Added full country functionality removed moments from the source resolving conflicts removed <<<< and >>> and ran grunt release
|
I have squashed and rebased and resolved the conflicts! :) |
|
Hi @mj1856 & @maggiepint, |
|
@alexgrace95 thank you soo much for doing this! I have been looking for this dataset for about 3 days and was about to give up and just create it myself. 🙏 |
|
Can we rebase the built files out of this pull? If so, will merge. |
Closed
|
Hello there, @alexgrace95 do you still have availability to rebase this PR ? :-) Would be much appreciated 🎉 |
|
Hi, yes will try to do it within the week, Happy New Year!
… On 31 Dec 2017, at 4:04 am, Cédric Malard ***@***.***> wrote:
Hello there, @alexgrace95 do you still have availability to rebase this PR ? :-) Would be much appreciated 🎉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Do you guys have an ETA on when this functionality will be merged? |
added 2 commits
March 19, 2018 00:31
|
Hi All, |
|
This is stupid. A highly sought and needed feature has not been merged in 3 years. |
|
I am also looking for this feature 👍 |
ellenaua
added a commit
that referenced
this pull request
Feb 19, 2020
ellenaua
added a commit
that referenced
this pull request
Feb 19, 2020
|
It's going tomorrow to production. Version 0.5.28 |
|
@ellenaua Let me know if you need it rebased or anything. Look forward to it being merged 😊 |
ellenaua
added a commit
that referenced
this pull request
Feb 20, 2020
ellenaua
added a commit
that referenced
this pull request
Feb 20, 2020
ellenaua
added a commit
that referenced
this pull request
Feb 21, 2020
ellenaua
added a commit
that referenced
this pull request
Feb 21, 2020
|
Tadaaam 🥇 🥇 |
This was referenced May 5, 2020
ellenaua
added a commit
that referenced
this pull request
May 16, 2020
* Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml Co-authored-by: Brinley Ang <brinley@unbolt.net>
ellenaua
added a commit
that referenced
this pull request
May 16, 2020
* Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
ellenaua
added a commit
that referenced
this pull request
May 16, 2020
* Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua
added a commit
that referenced
this pull request
May 17, 2020
* Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua
added a commit
that referenced
this pull request
May 17, 2020
* Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua
added a commit
that referenced
this pull request
May 17, 2020
…856) * Develop -> Master release 0.5.29 (#849) (#854) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise it fails (#855) * Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Release0.5.31 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua
added a commit
that referenced
this pull request
May 23, 2020
* Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise in Node 4 and 6 build fails (#856) * Develop -> Master release 0.5.29 (#849) (#854) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise it fails (#855) * Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Release0.5.31 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Added copyright info Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
|
Far as i see, there is no solution to do this? |
|
Same thoughts with @Soullighter can |
|
@Ivillacin |
ellenaua
added a commit
that referenced
this pull request
Nov 10, 2021
* Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise in Node 4 and 6 build fails (#856) * Develop -> Master release 0.5.29 (#849) (#854) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise it fails (#855) * Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <elenasharovar@gmail.com> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Release0.5.31 Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com> * Added copyright info * 2021a (#928) * Create issue_template.md * 2021a (#927) * 2021a * 2021a * 2021e Co-authored-by: Brinley Ang <brinley@unbolt.net> Co-authored-by: praneeth-m <praneeth.m@hotmail.com> Co-authored-by: Jackalex36 <beatboxace@gmail.com> Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com> Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for adding country functionality from metadata.
API:
var zones = moment.tz.zonesForCountry('US'); // returns ['America/Chicago', ' America/New_York', etc...]var country = moment.tz.zone('America/Los_Angeles').country; // returns ['US']Countries has been added to each zone containing the countries within the zone as well as a countries section containing the abbreviation and zones inside to both the packed and unpacked data.
I welcome any feedback and feel free to ask any questions or for further development.
Sorry for the delay adding the feature, I am a student at university and have a high workload at the moment.
Issues requesting the feature:
Original Pull Request: #377 ** had some difficulty with not being able to merge and so created new pull request, sorry for any inconvenience.